Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
T
third-party
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • cooperatic-foodcoops
  • third-party
  • Merge Requests
  • !231

Closed
Opened Jul 31, 2023 by Yvon Kerdoncuff@Yvon 
  • Report abuse
Report abuse

4880 quick fix : when counting products, when user edits + validates qty of…

4880 quick fix : when counting products, when user edits + validates qty of product without changing it, imitate behavior of direct clic on validate button so that product is still considered not updated, which prevents bug #4880

A tester en profondeur !

×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b 4880-rapports-reception-faux origin/4880-rapports-reception-faux

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout dev_cooperatic
git merge --no-ff 4880-rapports-reception-faux

Step 4. Push the result of the merge to GitLab

git push origin dev_cooperatic

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 2
  • Commits 1
  • Pipelines 1
  • Changes 1
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Damien Moulard
    @DamienM started a discussion on the diff Aug 07, 2023
    Last updated by Damien Moulard Aug 07, 2023
    reception/static/js/reception_produits.js
    1367 1367 productToEdit.package_qty = productToEdit.product_qty;
    1368 1368
    1369 1369 } else if (firstUpdate) {
    1370 // if the product is updated for the first time and productQty is equal to the newValue then the product is validated
    1371 isValid = true;
    1370 //If we came here, I think we just want to imitate the behavior of user clicking on Validate directly on the product instead of
    1371 //going further (https://redmine.coopdev.fr/issues/4880)
    1372 add_to_processed(productToEdit,true);
    • Damien Moulard @DamienM commented Aug 07, 2023
      Developer

      on ne passe pas par ici dans le cas que tu as défini (édition après édition et validation sans modif), donc ce fix n'est pas le bon.

      on ne passe pas par ici dans le cas que tu as défini (édition après édition et validation sans modif), donc ce fix n'est pas le bon.
    • Damien Moulard @DamienM commented Aug 07, 2023
      Developer

      De plus je ne suis pas sur que ça aurait résolu le soucis en soit car l'ajout à la liste processed se fait déjà, plus tard dans la fonction

      De plus je ne suis pas sur que ça aurait résolu le soucis en soit car l'ajout à la liste processed se fait déjà, plus tard dans la fonction
    Please register or sign in to reply
  • Damien Moulard @DamienM

    closed

    Aug 07, 2023

    closed

    closed
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
Reference: cooperatic-foodcoops/third-party!231