move child status update 'associated' to the end of the create_pair process so that odoo accepts it

members/admin.py

@@ -829,9 +829,7 @@ def create_pair(request):
                 child_id, 0, 'création de binôme (mise à zéro suppléant)'
             )
 
-            m = CagetteMember(child_id).unsubscribe_member()
-            # update child base account state
-            api.update("res.partner", [child_id], {'cooperative_state': "associated"})
+            CagetteMember(child_id).unsubscribe_member()
 
             # get barcode rule id
             bbcode_rule = api.search_read("barcode.rule", [['for_associated_people', "=", True]], ['id'])[0]
@@ -850,6 +848,11 @@ def create_pair(request):
             attached_account = api.create('res.partner', child)
             # generate_base
             api.execute('res.partner', 'generate_base', [attached_account])
+
+            # update child base account state after contact is created otherwise odoo complains that
+            # setting status associated is not allowed
+            api.update("res.partner", [child_id], {'cooperative_state': "associated"})
+
             response = JsonResponse({"message": "Succesfuly paired members"}, status=200)
         else:
             response = JsonResponse({"message": "Unauthorized"}, status=403)