Skip to content

Q
question2answer
Commit c6bce760 by pupi1985
Options

Avoid throwing an error on non-existent posts

parent b74d7099
Showing with 161 additions and 121 deletions
qa-include/app/admin.php
...@@ -649,144 +649,184 @@ function qa_admin_single_click_array($entityid, $action) ...@@ -649,144 +649,184 @@ function qa_admin_single_click_array($entityid, $action)
} else { // something to do with a post } else { // something to do with a post
require_once QA_INCLUDE_DIR . 'app/posts.php'; require_once QA_INCLUDE_DIR . 'app/posts.php';
$post = qa_post_get_full($entityid); $post = qa_db_single_select(qa_db_full_post_selectspec(null, $entityid));
if (isset($post)) {
$queued = (substr($post['type'], 1) == '_QUEUED');
// Handle non-existent posts
if ($post === null) {
switch ($action) { switch ($action) {
case 'approve': case 'approve':
case 'reject': case 'reject':
$entityCount = (int)qa_opt('cache_queuedcount'); $entityCount = (int)qa_opt('cache_queuedcount');
if (!$queued) { $selector = '.qa-nav-sub-counter-moderate';
$response['result'] = 'error';
$response['error']['type'] = 'post-not-queued';
$response['error']['message'] = qa_lang_html('main/general_error');
$response['domUpdates'] = array(
array(
'selector' => '.qa-nav-sub-counter-moderate',
'html' => max($entityCount, 0),
),
array(
'selector' => '#p' . $entityid,
'action' => 'conceal',
),
);
} elseif (qa_user_post_permit_error('permit_moderate', $post) !== false) {
$response['result'] = 'error';
$response['error']['type'] = 'no-permission';
$response['error']['message'] = qa_lang_html('users/no_permission');
$response['error']['severity'] = 'fatal';
} else {
$postStatus = $action === 'approve'
? QA_POST_STATUS_NORMAL
: QA_POST_STATUS_HIDDEN; // 'reject'
qa_post_set_status($entityid, $postStatus, $userid);
$response['result'] = 'success';
$response['domUpdates'] = array(
array(
'selector' => '.qa-nav-sub-counter-moderate',
'html' => max($entityCount - 1, 0),
),
array(
'selector' => '#p' . $entityid,
'action' => 'conceal',
),
);
}
break; break;
case 'reshow': case 'reshow':
case 'delete': case 'delete':
$entityCount = (int)qa_opt('cache_hiddencount'); $entityCount = (int)qa_opt('cache_hiddencount');
if (!$post['hidden']) { $selector = '.qa-nav-sub-counter-hidden';
$response['result'] = 'error';
$response['error']['type'] = 'post-not-hidden';
$response['error']['message'] = qa_lang_html('main/general_error');
$response['domUpdates'] = array(
array(
'selector' => '.qa-nav-sub-counter-hidden',
'html' => max($entityCount, 0),
),
array(
'selector' => '#p' . $entityid,
'action' => 'conceal',
),
);
} elseif (qa_user_post_permit_error('permit_hide_show', $post) !== false) {
$response['result'] = 'error';
$response['error']['type'] = 'no-permission';
$response['error']['message'] = qa_lang_html('users/no_permission');
$response['error']['severity'] = 'fatal';
} else {
if ($action === 'reshow') {
qa_post_set_status($entityid, QA_POST_STATUS_NORMAL, $userid);
} else { // 'delete'
qa_post_delete($entityid);
}
$response['result'] = 'success';
$response['domUpdates'] = array(
array(
'selector' => '.qa-nav-sub-counter-hidden',
'html' => max($entityCount - 1, 0),
),
array(
'selector' => '#p' . $entityid,
'action' => 'conceal',
),
);
}
break; break;
case 'hide': case 'hide':
case 'clearflags': case 'clearflags':
$entityCount = (int)qa_opt('cache_flaggedcount'); $entityCount = (int)qa_opt('cache_flaggedcount');
if ($action === 'hide' && $queued) { $selector = '.qa-nav-sub-counter-flagged';
$response['result'] = 'error'; break;
$response['error']['type'] = 'post-queued'; default:
$response['error']['message'] = qa_lang_html('main/general_error'); $selector = '';
$response['domUpdates'] = array( $entityCount = 0;
array( }
'selector' => '.qa-nav-sub-counter-flagged',
'html' => max($entityCount, 0),
),
array(
'selector' => '#p' . $entityid,
'action' => 'conceal',
),
);
} elseif (qa_user_post_permit_error('permit_hide_show', $post) !== false) {
$response['result'] = 'error';
$response['error']['type'] = 'no-permission';
$response['error']['message'] = qa_lang_html('users/no_permission');
$response['error']['severity'] = 'fatal';
} else {
if ($action === 'hide') {
qa_post_set_status($entityid, QA_POST_STATUS_HIDDEN, $userid);
} else { // 'clearflags'
require_once QA_INCLUDE_DIR . 'app/votes.php';
qa_flags_clear_all($post, $userid, qa_get_logged_in_handle(), null); return array(
} 'result' => 'error',
'error' => array(
'type' => 'post-not-found',
'message' => qa_lang_html('main/general_error'),
),
'domUpdates' => array(
array(
'selector' => $selector,
'html' => $entityCount,
),
array(
'selector' => '#p' . $entityid,
'action' => 'conceal',
),
),
);
}
$response['result'] = 'success'; $queued = (substr($post['type'], 1) == '_QUEUED');
$response['domUpdates'] = array(
array( switch ($action) {
'selector' => '.qa-nav-sub-counter-flagged', case 'approve':
'html' => max($entityCount - 1, 0), case 'reject':
), $entityCount = (int)qa_opt('cache_queuedcount');
array( if (!$queued) {
'selector' => '#p' . $entityid, $response['result'] = 'error';
'action' => 'conceal', $response['error']['type'] = 'post-not-queued';
), $response['error']['message'] = qa_lang_html('main/general_error');
); $response['domUpdates'] = array(
array(
'selector' => '.qa-nav-sub-counter-moderate',
'html' => $entityCount,
),
array(
'selector' => '#p' . $entityid,
'action' => 'conceal',
),
);
} elseif (qa_user_post_permit_error('permit_moderate', $post) !== false) {
$response['result'] = 'error';
$response['error']['type'] = 'no-permission';
$response['error']['message'] = qa_lang_html('users/no_permission');
$response['error']['severity'] = 'fatal';
} else {
$postStatus = $action === 'approve'
? QA_POST_STATUS_NORMAL
: QA_POST_STATUS_HIDDEN; // 'reject'
qa_post_set_status($entityid, $postStatus, $userid);
$response['result'] = 'success';
$response['domUpdates'] = array(
array(
'selector' => '.qa-nav-sub-counter-moderate',
'html' => max($entityCount - 1, 0),
),
array(
'selector' => '#p' . $entityid,
'action' => 'conceal',
),
);
}
break;
case 'reshow':
case 'delete':
$entityCount = (int)qa_opt('cache_hiddencount');
if (!$post['hidden']) {
$response['result'] = 'error';
$response['error']['type'] = 'post-not-hidden';
$response['error']['message'] = qa_lang_html('main/general_error');
$response['domUpdates'] = array(
array(
'selector' => '.qa-nav-sub-counter-hidden',
'html' => $entityCount,
),
array(
'selector' => '#p' . $entityid,
'action' => 'conceal',
),
);
} elseif (qa_user_post_permit_error('permit_hide_show', $post) !== false) {
$response['result'] = 'error';
$response['error']['type'] = 'no-permission';
$response['error']['message'] = qa_lang_html('users/no_permission');
$response['error']['severity'] = 'fatal';
} else {
if ($action === 'reshow') {
qa_post_set_status($entityid, QA_POST_STATUS_NORMAL, $userid);
} else { // 'delete'
qa_post_delete($entityid);
} }
break;
default: $response['result'] = 'success';
} $response['domUpdates'] = array(
array(
'selector' => '.qa-nav-sub-counter-hidden',
'html' => max($entityCount - 1, 0),
),
array(
'selector' => '#p' . $entityid,
'action' => 'conceal',
),
);
}
break;
case 'hide':
case 'clearflags':
$entityCount = (int)qa_opt('cache_flaggedcount');
if ($action === 'hide' && $queued) {
$response['result'] = 'error';
$response['error']['type'] = 'post-queued';
$response['error']['message'] = qa_lang_html('main/general_error');
$response['domUpdates'] = array(
array(
'selector' => '.qa-nav-sub-counter-flagged',
'html' => $entityCount,
),
array(
'selector' => '#p' . $entityid,
'action' => 'conceal',
),
);
} elseif (qa_user_post_permit_error('permit_hide_show', $post) !== false) {
$response['result'] = 'error';
$response['error']['type'] = 'no-permission';
$response['error']['message'] = qa_lang_html('users/no_permission');
$response['error']['severity'] = 'fatal';
} else {
if ($action === 'hide') {
qa_post_set_status($entityid, QA_POST_STATUS_HIDDEN, $userid);
} else { // 'clearflags'
require_once QA_INCLUDE_DIR . 'app/votes.php';
qa_flags_clear_all($post, $userid, qa_get_logged_in_handle(), null);
}
$response['result'] = 'success';
$response['domUpdates'] = array(
array(
'selector' => '.qa-nav-sub-counter-flagged',
'html' => max($entityCount - 1, 0),
),
array(
'selector' => '#p' . $entityid,
'action' => 'conceal',
),
);
}
break;
default:
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment