Fix redirects for guest users, login error, already-defined constant

qa-include/util/external-users-joomla.php

@@ -51,16 +51,11 @@ function qa_get_logged_in_user()
 
     if($user) {
       if($user->guest || $user->block) {
-        header('location:'.$config_urls['denied']);
-        die;
+        return null;
       }
 
       $access = $jhelper->trigger_access_event($user);
 
-      if(!$access['view']) {     //must be in a group that has the view level set at least.
-        header('location:'.$config_urls['denied']);
-        die;
-      }
       $level = QA_USER_LEVEL_BASIC;
       if($access['post'])  {$level = QA_USER_LEVEL_APPROVED;}
       if($access['edit'])  {$level = QA_USER_LEVEL_EDITOR;}

qa-include/util/qa-joomla-helper.php

@@ -48,7 +48,11 @@ class qa_joomla_helper {
 
     private function load_joomla_app()
     {
-        define( '_JEXEC', 1 ); //This will define the _JEXEC constant that will allow us to access the rest of the Joomla framework
+        // This will define the _JEXEC constant that will allow us to access the rest of the Joomla framework
+        if (!defined('_JEXEC')) {
+            define('_JEXEC', 1);
+        }
+
         require_once(JPATH_BASE.'/includes/defines.php' );
         require_once(JPATH_BASE.'/includes/framework.php' );
         // Instantiate the application.
@@ -69,7 +73,7 @@ class qa_joomla_helper {
 
     public function get_userid($username)
     {
-        JUserHelper::getUserId($username);
+        return JUserHelper::getUserId($username);
     }
 
     function trigger_access_event($user)
@@ -142,7 +146,7 @@ class qa_joomla_default_integration
         list($user) = $args;
 
         return array(
-            'view' => !($user->guest || $user->block),
+            'view' => true,
             'post' => !($user->guest || $user->block),
             'edit' => $user->authorise('core.edit'),
             'mod'  => $user->authorise('core.edit.state'),