Commit 6f4ca3fb by Daniel Ruf

set HttpOnly flag to true

parent 00c03c3e
...@@ -167,7 +167,7 @@ ...@@ -167,7 +167,7 @@
else { else {
if ($noticeid=='visitor') if ($noticeid=='visitor')
setcookie('qa_noticed', 1, time()+86400*3650, '/', QA_COOKIE_DOMAIN); setcookie('qa_noticed', 1, time()+86400*3650, '/', QA_COOKIE_DOMAIN, (bool)ini_get('session.cookie_secure'), true);
elseif ($noticeid=='welcome') { elseif ($noticeid=='welcome') {
require_once QA_INCLUDE_DIR.'db/users.php'; require_once QA_INCLUDE_DIR.'db/users.php';
...@@ -217,7 +217,7 @@ ...@@ -217,7 +217,7 @@
if ($firstlower == 'admin') { if ($firstlower == 'admin') {
$_COOKIE['qa_admin_last'] = $requestlower; // for navigation tab now... $_COOKIE['qa_admin_last'] = $requestlower; // for navigation tab now...
setcookie('qa_admin_last', $_COOKIE['qa_admin_last'], 0, '/', QA_COOKIE_DOMAIN); // ...and in future setcookie('qa_admin_last', $_COOKIE['qa_admin_last'], 0, '/', QA_COOKIE_DOMAIN, (bool)ini_get('session.cookie_secure'), true); // ...and in future
} }
if (isset($qa_content)) if (isset($qa_content))
...@@ -756,7 +756,7 @@ ...@@ -756,7 +756,7 @@
$qa_content['notices'][]=qa_notice_form('visitor', qa_opt('notice_visitor')); $qa_content['notices'][]=qa_notice_form('visitor', qa_opt('notice_visitor'));
} else { } else {
setcookie('qa_noticed', 1, time()+86400*3650, '/', QA_COOKIE_DOMAIN); // don't show first-time notice if a user has logged in setcookie('qa_noticed', 1, time()+86400*3650, '/', QA_COOKIE_DOMAIN, (bool)ini_get('session.cookie_secure'), true); // don't show first-time notice if a user has logged in
if (qa_opt('show_notice_welcome') && (qa_get_logged_in_flags() & QA_USER_FLAGS_WELCOME_NOTICE) ) if (qa_opt('show_notice_welcome') && (qa_get_logged_in_flags() & QA_USER_FLAGS_WELCOME_NOTICE) )
if ( ($requestlower!='confirm') && ($requestlower!='account') ) // let people finish registering in peace if ( ($requestlower!='confirm') && ($requestlower!='account') ) // let people finish registering in peace
...@@ -836,4 +836,4 @@ ...@@ -836,4 +836,4 @@
/* /*
Omit PHP closing tag to help avoid accidental output Omit PHP closing tag to help avoid accidental output
*/ */
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment