Minor changes to PHPDocs and removal of variable declarations

qa-content/qa-ask.js

@@ -221,7 +221,7 @@ function qa_category_select(idprefix, startpath)
 									var addedoption = false;
 
 									if (lines.length > 2) {
-										var subelem = elem.parentNode.insertBefore(document.createElement('span'), elem.nextSibling);
+										subelem = elem.parentNode.insertBefore(document.createElement('span'), elem.nextSibling);
 										subelem.id = idprefix + '_' + l + '_sub';
 										subelem.innerHTML = ' ';
 

qa-content/qa-global.js

@@ -92,7 +92,7 @@ function qa_vote_click(elem)
 				var mess = document.getElementById('errorbox');
 
 				if (!mess) {
-					var mess = document.createElement('div');
+					mess = document.createElement('div');
 					mess.id = 'errorbox';
 					mess.className = 'qa-error';
 					mess.innerHTML = lines[1];
@@ -648,7 +648,7 @@ function qa_category_select(idprefix, startpath)
 									var addedoption = false;
 
 									if (lines.length > 2) {
-										var subelem = elem.parentNode.insertBefore(document.createElement('span'), elem.nextSibling);
+										subelem = elem.parentNode.insertBefore(document.createElement('span'), elem.nextSibling);
 										subelem.id = idprefix + '_' + l + '_sub';
 										subelem.innerHTML = ' ';
 

qa-content/qa-page.js

@@ -92,7 +92,7 @@ function qa_vote_click(elem)
 				var mess = document.getElementById('errorbox');
 
 				if (!mess) {
-					var mess = document.createElement('div');
+					mess = document.createElement('div');
 					mess.id = 'errorbox';
 					mess.className = 'qa-error';
 					mess.innerHTML = lines[1];

qa-include/Q2A/Storage/CacheFactory.php

@@ -29,7 +29,7 @@ class Q2A_Storage_CacheFactory
 
 	/**
 	 * Get the appropriate cache handler.
-	 * @return Q2A_Storage_CacheInterface The cache handler.
+	 * @return Q2A_Storage_CacheDriver The cache handler.
 	 */
 	public static function getCacheDriver()
 	{

qa-include/app/options.php

@@ -645,7 +645,7 @@ function qa_message_html_defaults()
 
 /**
  * Return $voteview parameter to pass to qa_post_html_fields() in /qa-include/app/format.php.
- * @param $postorbasetype The post, or for compatibility just a basetype, i.e. 'Q', 'A' or 'C'
+ * @param array|string $postorbasetype The post, or for compatibility just a basetype, i.e. 'Q', 'A' or 'C'
  * @param bool $full Whether full post is shown
  * @param bool $enabledif Whether to do checks for voting buttons (i.e. will always disable voting if false)
  * @return bool|string Possible values:

qa-include/app/posts.php

@@ -388,7 +388,7 @@ function qa_post_userid_to_handle($userid)
  * Return the textual rendition of $content in $format (used for indexing).
  * @param $content
  * @param $format
- * @return
+ * @return string
  */
 function qa_post_content_to_text($content, $format)
 {

qa-include/db/hotness.php

@@ -44,8 +44,8 @@ function qa_db_increment_views($postid)
 /**
  * Recalculate the hotness in the database for one or more posts.
  *
- * @param $firstpostid First post to recalculate (or only post if $lastpostid is null).
- * @param $lastpostid Last post in the range to recalculate.
+ * @param int $firstpostid First post to recalculate (or only post if $lastpostid is null).
+ * @param int $lastpostid Last post in the range to recalculate.
  * @param bool $viewincrement Deprecated - view counter is now incremented separately. Previously, would increment the post's
  *   views and include that in the hotness calculation.
  * @return void

qa-include/qa-base.php

@@ -896,7 +896,7 @@ function qa_list_modules($type)
  * Return an array containing information about the module of $type named $name
  * @param $type
  * @param $name
- * @return
+ * @return array
  */
 function qa_get_module_info($type, $name)
 {

qa-include/qa-db.php

@@ -451,6 +451,7 @@ function qa_db_list_tables_lc()
  *
  * @param bool $onlyTablesWithPrefix Determine if the result should only include tables with the
  * QA_MYSQL_TABLE_PREFIX or if it should include all tables in the database.
+ * @return array
  */
 function qa_db_list_tables($onlyTablesWithPrefix = false)
 {

qa-include/qa-url-test.php

@@ -24,7 +24,7 @@ if (qa_gpc_to_string(@$_GET['param']) == QA_URL_TEST_STRING) {
 
 	echo '<html><body style="margin:0; padding:0;">';
 	echo '<table width="100%" height="100%" cellspacing="0" cellpadding="0">';
-	echo '<tr valign="middle"><td align="center" style="border-style:solid; border-width:1px; background-color:#fff; ';
+	echo '<tr valign="middle"><td align="center" style="border: 1px solid; background-color:#fff; ';
 	echo qa_admin_url_test_html();
 	echo '/td></tr></table>';
 	echo '</body></html>';