minimal refactoring + comments

members/admin.py

@@ -394,7 +394,7 @@ def update_members_makeups(request):
     if is_connected_user is True:
         members_data = json.loads(request.body.decode())
 
-        # Make sure update would not unsubscribe member
+        # Perform checks and compute some data in a loop on members.
         cs = CagetteShift()
         unsubscription_limit = api.get_system_param('lacagette_membership.points_limit_to_get_unsubscribed')
         for member_data in members_data:
@@ -408,14 +408,16 @@ def update_members_makeups(request):
                 error["error"] = "L'opération de rattrapage a été annulée car le nombre de rattrapage cible est négatif."
                 return JsonResponse(error, status=400)
             makeup_change_count = target_makeups_nb - cs.get_member_makeups_to_do(cm.id)
-            members_data[member_data["member_id"]]["points_diff"] = - makeup_change_count
             points_target = cm.get_member_points("standard") - makeup_change_count
             if points_target <= unsubscription_limit:
                 error = []
                 error["error"]\
                     = "L'ajout de rattrapage a été annulé car il provoquerait la désinscription d'un membre."
                 return JsonResponse(error, status=400)
+            # Save computed data in member_data. It will be useful to update makeups and points.
+            members_data[member_data["member_id"]]["points_diff"] = - makeup_change_count
 
+        # Update makeups and points
         res["res"] = []
         update_members_makeups_core(members_data, res)
         response = JsonResponse(res)