#2825 : improve alias recognition

products/models.py

@@ -520,6 +520,8 @@ class CagetteProducts(models.Model):
             rules = OdooAPI().search_read('barcode.rule', c, ['pattern', 'type', 'alias'], order="sequence ASC")
             # As rules are ordered by sequence, let's find where to stop (.* pattern)
             stop_idx = len(rules) - 1
+            #  .* (catchall) rules, if exists, may be not the last rule
+            #  let's find it and set stop_idx consequently
             i = 0
             for r in rules:
                 if r['pattern'] == ".*":

products/static/js/barcodes.js

@@ -112,7 +112,14 @@ IFCBarcodes = {
 
         // let's seek "normalized" bc in codes array or alias map
         for (alias in this.aliases) {
-            if (bc == alias) {
+            /*
+                bc.indexOf(alias) === 0
+                could be enough, 
+                but is used to keep in mind .* caracters
+                can be used in rules (have been cleaned before beeing here)
+             */
+            if (bc == alias || bc.indexOf(alias) === 0) {
+
                 is_alias = true;
                 for (barcode in this.codes) {
                     if (barcode == this.aliases[alias]) {

shelfs/static/js/shelfs_admin.js

@@ -368,9 +368,9 @@ var addProductToList = async function(barcode) {
     //It could also be a wrong reading one
 
     odoo_product = barcodes.get_corresponding_odoo_product(barcode);
-
+    if (odoo_product) {
         if (is_product_in_shelf_adding_queue_list(odoo_product.data[barcodes.keys.id])) {
-        console.log("Already added product");
+            alert("Produit déjà présent dans la liste.");
         } else {
             add_to_shelf_product_ids.push(odoo_product.data[4]);
             if (odoo_product === null) {
@@ -393,6 +393,7 @@ var addProductToList = async function(barcode) {
                     .html(add_pdts_btn_text);
             }
         }
+    }
 };
 
 var addProducts = async function() {