to perform stock change from third-party apps, call action_validate instead of…

to perform stock change from third-party apps, call action_validate instead of action_done (deleted) and show error if missing data are required

inventory/models.py

@@ -418,17 +418,21 @@ class CagetteInventory(models.Model):
                 # Set inventory as 'done' even if some products missed
                 res = api.execute('stock.inventory', 'action_validate', [inv])
                 if not res:
-                    action_validate_issue = "Action validate did not return True"
+                    done.append('Closed inventory')
+                else:
+                    action_validate_issue = "Action validate returned something."
                     coop_logger.error(action_validate_issue)
                     errors.append(action_validate_issue)
-                    if name in res:
-                        coop_logger.error('Action validate returned wizard named %s', res['name'])
-                        error.extend(
+                    if isinstance(res, dict) and 'name' in res:
+                        coop_logger.error('Action validate wanted to return wizard named %s which is not possible from third-party app.', res['name'])
+                        error.extend([
                             'Action validate wanted to return wizard named :',
                             res['name'],
                             'which is not possible from third-party app.'
-                        )
-                done.append('Closed inventory')
+                        ])
+                    else: #well, in that case, just try to print the value returned by res to help debugging...
+                        coop_logger.error(res)
+                        errors.append(res)
         except Exception as e:
             if not (MARSHALL_ERROR in str(e)):
                 coop_logger.error("update_stock_with_shelf_inventory_data %s",str(e))

products/views.py

@@ -186,6 +186,8 @@ def commit_actions_on_product(request):
                     if res_inventory['errors'] or res_inventory['missed']:
                         res["code"] = "error_stock_update"
                         res["error"] = res_inventory['errors']
+                        res["done"] = res_inventory["done"]
+                        res["inv_id"] = res_inventory["inv_id"]
                         return JsonResponse(res, status=500)
                 except Exception as e:
                     res["code"] = "error_stock_update"