Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
K
kohinos-tav
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • agplv3
  • kohinos-tav
  • Merge Requests
  • !85

Merged
Opened Apr 24, 2024 by Yvon Kerdoncuff@Yvon 
  • Report abuse
Report abuse

6260 faux positif dans detection paiement recurrent en cours

  • Discussion 3
  • Commits 3
  • Changes 2
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Damien Moulard
    @DamienM started a discussion on an old version of the diff Apr 25, 2024
    Last updated by Yvon Kerdoncuff Apr 25, 2024
    src/Utils/TAVCotisationUtils.php
    54 55
    55 56 $res = "";
    56 57 foreach($recurringPayments as $p) {
    57 $reason = "";
    58 if($p->isRecurringPaymentEndedOrExpired($reason) !== true) {
    59 $res .= ($reason . " ");
    58 if ($p->getStatus() !== GetHumanStatus::STATUS_FAILED) { //filter out failed payments
    • Damien Moulard @DamienM commented Apr 25, 2024
      Master

      attention il y a d'autres statuts d'échec (STATUS_CANCELED, STATUS_EXPIRED)

      attention il y a d'autres statuts d'échec (STATUS_CANCELED, STATUS_EXPIRED)
    • Damien Moulard @DamienM commented Apr 25, 2024
      Master

      une fois rajoutés, ok pour merge

      une fois rajoutés, ok pour merge
    • Yvon Kerdoncuff @Yvon

      changed this line in version 2 of the diff

      Apr 25, 2024

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gl.cooperatic.fr/cooperatic/kohinos-tav/merge_requests/85/diffs?diff_id=2979&start_sha=3851052de7aa941dc13b4dd0e2f1b4d233e7d594#a3ddd4b8e3b50dfe660f2ca3ec8b0d34a2b8c77f_58_58)
      Toggle commit list
    • Yvon Kerdoncuff @Yvon commented Apr 25, 2024
      Master

      ok, et j'ai aussi ajouté un commentaire pour expliquer pourquoi la vérification de ces trois états n'est pas suffisante

      ok, et j'ai aussi ajouté un commentaire pour expliquer pourquoi la vérification de ces trois états n'est pas suffisante
    Please register or sign in to reply
  • Yvon Kerdoncuff @Yvon

    added 1 commit

    • 496b7a54 - when checking existing recurrent payment, discard not only those with FAILED…

    Compare with previous version

    Apr 25, 2024

    added 1 commit

    • 496b7a54 - when checking existing recurrent payment, discard not only those with FAILED…

    Compare with previous version

    added 1 commit <ul><li>496b7a54 - when checking existing recurrent payment, discard not only those with FAILED…</li></ul> [Compare with previous version](https://gl.cooperatic.fr/cooperatic/kohinos-tav/merge_requests/85/diffs?diff_id=2979&start_sha=3851052de7aa941dc13b4dd0e2f1b4d233e7d594)
    Toggle commit list
  • Yvon Kerdoncuff @Yvon

    merged

    Apr 25, 2024

    merged

    merged
    Toggle commit list
  • Yvon Kerdoncuff @Yvon

    mentioned in commit 15b362e3

    Apr 25, 2024

    mentioned in commit 15b362e3

    mentioned in commit 15b362e3a984c0d10ba813c44e42ea0c0c720afc
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
Reference: agplv3/kohinos-tav!85
×

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.