Skip to content

K
kohinos-tav
Opened by  

vitrine prestataire : display questionnaire as form in readonly mode using third…

vitrine prestataire : display questionnaire as form in readonly mode using third value to review option

{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Damien Moulard
    @DamienM started a discussion on an old version of the diff
    Resolved by Damien Moulard
    src/Form/Type/SelfEvalPrestaQuizType.php
    158 162 {
    159 163 $resolver->setDefaults([
    160 164 'data_class' => SelfEvalPrestaQuiz::class,
    161 'review' => false //decide if prestataire is filling the form or if an admin is reviewing
    165 //review says if prestataire is filling the form (false),
    • Damien Moulard @DamienM commented
      Master

      Pas fan d'avoir une variable à "false", "true" ou "readonly". Un booléen ne devrait avoir que deux valeurs possibles.

      Je propose de changer par une variable de type string qui indique le contexte ("admin_review"...)

      Edited by Damien Moulard
    • Yvon Kerdoncuff @Yvon commented
      Master

      je suis d'accord, j'ai refait ça mieux

    • Yvon Kerdoncuff @Yvon

      changed this line in version 2 of the diff

      changed this line in version 2 of the diff

      Toggle commit list
    Please register or sign in to reply
  • Damien Moulard
    @DamienM started a discussion
    Resolved by Damien Moulard
    • Damien Moulard @DamienM commented
      Master

      Il commence à y avoir pas mal de fichiers de template liés à l'autoévaluation, en terme d'architecture de fichiers je propose de créer un sous dossier "selfeval" par exemple sous le dossier "tav"

      Edited by Damien Moulard
    • Yvon Kerdoncuff @Yvon commented
      Master

      riche idée

    Please register or sign in to reply
  • Damien Moulard
    @DamienM started a discussion
    Resolved by Damien Moulard
    Please register or sign in to reply
  • Yvon Kerdoncuff @Yvon

    added 3 commits

    • 62ce2ea5 - use cleaner state values for selfevalformtype operating mode
    • 99f4d436 - put all prestaquiz tempaltes in new dir and shorten names
    • 4a099ca7 - show questionnaire section in presta vitrine only if questionnaire is available

    Compare with previous version

    added 3 commits

    • 62ce2ea5 - use cleaner state values for selfevalformtype operating mode
    • 99f4d436 - put all prestaquiz tempaltes in new dir and shorten names
    • 4a099ca7 - show questionnaire section in presta vitrine only if questionnaire is available

    Compare with previous version

    Toggle commit list
  • Damien Moulard @DamienM

    merged

    merged

    Toggle commit list
  • Damien Moulard @DamienM

    mentioned in commit 1ac5109e

    mentioned in commit 1ac5109e

    Toggle commit list
  • Damien Moulard @DamienM

    resolved all discussions

    resolved all discussions

    Toggle commit list
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment