Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
K
kohinos-tav
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • agplv3
  • kohinos-tav
  • Merge Requests
  • !118

Merged
Opened Sep 30, 2024 by Yvon Kerdoncuff@Yvon 
  • Report abuse
Report abuse

payment duplicates

Edited Nov 14, 2024 by Yvon Kerdoncuff
  • Discussion 2
  • Commits 11
  • Changes 5
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Yvon Kerdoncuff @Yvon

    added 1 commit

    • 52628248 - a tester : redirige vers une page de paiement déjà existante

    Compare with previous version

    Sep 30, 2024

    added 1 commit

    • 52628248 - a tester : redirige vers une page de paiement déjà existante

    Compare with previous version

    added 1 commit <ul><li>52628248 - a tester : redirige vers une page de paiement déjà existante</li></ul> [Compare with previous version](https://gl.cooperatic.fr/cooperatic/kohinos-tav/merge_requests/118/diffs?diff_id=3407&start_sha=e0cdca17ce7585627b3cc7e1015ddcbfbd954db6)
    Toggle commit list
  • Yvon Kerdoncuff @Yvon

    changed title from WIP: cosmetic to WIP: payment duplicates

    Sep 30, 2024

    changed title from WIP: cosmetic to WIP: payment duplicates

    changed title from **WIP: {-cosmetic-}** to **WIP: {+payment duplicates+}**
    Toggle commit list
  • Yvon Kerdoncuff @Yvon

    added 1 commit

    • 54cc9f01 - redirige vers une page de paiement déjà existante : use 10 minutes fixed payzen page timeout

    Compare with previous version

    Oct 07, 2024

    added 1 commit

    • 54cc9f01 - redirige vers une page de paiement déjà existante : use 10 minutes fixed payzen page timeout

    Compare with previous version

    added 1 commit <ul><li>54cc9f01 - redirige vers une page de paiement déjà existante : use 10 minutes fixed payzen page timeout</li></ul> [Compare with previous version](https://gl.cooperatic.fr/cooperatic/kohinos-tav/merge_requests/118/diffs?diff_id=3423&start_sha=52628248589708a905018030c6f64d46fdb0fa5d)
    Toggle commit list
  • Yvon Kerdoncuff @Yvon

    added 1 commit

    • 0f70de63 - minor fix

    Compare with previous version

    Oct 07, 2024

    added 1 commit

    • 0f70de63 - minor fix

    Compare with previous version

    added 1 commit <ul><li>0f70de63 - minor fix</li></ul> [Compare with previous version](https://gl.cooperatic.fr/cooperatic/kohinos-tav/merge_requests/118/diffs?diff_id=3424&start_sha=54cc9f01577f783c8c15f405461ccdf7146d1017)
    Toggle commit list
  • Yvon Kerdoncuff @Yvon

    added 1 commit

    • 9186ba4b - take into account payment lines with status new or null

    Compare with previous version

    Oct 07, 2024

    added 1 commit

    • 9186ba4b - take into account payment lines with status new or null

    Compare with previous version

    added 1 commit <ul><li>9186ba4b - take into account payment lines with status new or null</li></ul> [Compare with previous version](https://gl.cooperatic.fr/cooperatic/kohinos-tav/merge_requests/118/diffs?diff_id=3425&start_sha=0f70de632653c323c2c546e9fdbbd0c025b010e0)
    Toggle commit list
  • Yvon Kerdoncuff @Yvon

    added 1 commit

    • eda9a4a9 - remove debug

    Compare with previous version

    Oct 07, 2024

    added 1 commit

    • eda9a4a9 - remove debug

    Compare with previous version

    added 1 commit <ul><li>eda9a4a9 - remove debug</li></ul> [Compare with previous version](https://gl.cooperatic.fr/cooperatic/kohinos-tav/merge_requests/118/diffs?diff_id=3426&start_sha=9186ba4bbf64d5a96492c38248c99d2c5931856b)
    Toggle commit list
  • Yvon Kerdoncuff @Yvon

    added 1 commit

    • 4d371b7e - typo

    Compare with previous version

    Oct 07, 2024

    added 1 commit

    • 4d371b7e - typo

    Compare with previous version

    added 1 commit <ul><li>4d371b7e - typo</li></ul> [Compare with previous version](https://gl.cooperatic.fr/cooperatic/kohinos-tav/merge_requests/118/diffs?diff_id=3427&start_sha=eda9a4a9aa4555817338ed50cd532f898a0c4b1a)
    Toggle commit list
  • Yvon Kerdoncuff @Yvon

    added 1 commit

    • 83738085 - block user if another starting payment has been found

    Compare with previous version

    Nov 14, 2024

    added 1 commit

    • 83738085 - block user if another starting payment has been found

    Compare with previous version

    added 1 commit <ul><li>83738085 - block user if another starting payment has been found</li></ul> [Compare with previous version](https://gl.cooperatic.fr/cooperatic/kohinos-tav/merge_requests/118/diffs?diff_id=3530&start_sha=4d371b7e9d0554c5d9286fe9fe4a7a905d989327)
    Toggle commit list
  • Yvon Kerdoncuff @Yvon

    added 1 commit

    • 62d20081 - remove wrong comment

    Compare with previous version

    Nov 14, 2024

    added 1 commit

    • 62d20081 - remove wrong comment

    Compare with previous version

    added 1 commit <ul><li>62d20081 - remove wrong comment</li></ul> [Compare with previous version](https://gl.cooperatic.fr/cooperatic/kohinos-tav/merge_requests/118/diffs?diff_id=3531&start_sha=83738085fa0f35e7055d40aab939aa87ca37d445)
    Toggle commit list
  • Yvon Kerdoncuff @Yvon

    added 1 commit

    • 9a43fb2e - improve user message

    Compare with previous version

    Nov 14, 2024

    added 1 commit

    • 9a43fb2e - improve user message

    Compare with previous version

    added 1 commit <ul><li>9a43fb2e - improve user message</li></ul> [Compare with previous version](https://gl.cooperatic.fr/cooperatic/kohinos-tav/merge_requests/118/diffs?diff_id=3532&start_sha=62d2008188b00de41d21bb468e389337bfd36fd2)
    Toggle commit list
  • Yvon Kerdoncuff @Yvon

    added 9 commits

    • 9a43fb2e...609fe300 - 8 commits from branch develop
    • 3e5789d7 - Merge branch 'develop' into 6715-payment-duplicates

    Compare with previous version

    Nov 14, 2024

    added 9 commits

    • 9a43fb2e...609fe300 - 8 commits from branch develop
    • 3e5789d7 - Merge branch 'develop' into 6715-payment-duplicates

    Compare with previous version

    added 9 commits <ul><li>9a43fb2e...609fe300 - 8 commits from branch <code>develop</code></li><li>3e5789d7 - Merge branch &#39;develop&#39; into 6715-payment-duplicates</li></ul> [Compare with previous version](https://gl.cooperatic.fr/cooperatic/kohinos-tav/merge_requests/118/diffs?diff_id=3533&start_sha=9a43fb2e3988b77be995ad9b6938d9b354ca3c17)
    Toggle commit list
  • Yvon Kerdoncuff @Yvon

    unmarked as a Work In Progress

    Nov 14, 2024

    unmarked as a Work In Progress

    unmarked as a **Work In Progress**
    Toggle commit list
  • Damien Moulard
    @DamienM started a discussion on an old version of the diff Nov 15, 2024
    Last updated by Yvon Kerdoncuff Nov 19, 2024
    src/Controller/PaymentController.php
    141 145 $captureToken->setTargetUrl($targetUrl);
    142 146 $captureToken->setAfterUrl($afterUrl);
    143 147
    148 $targetUrl = $captureToken->getTargetUrl();
    149 /* @var Payment $payment */
    150 if (!$payment->getPayzenStartingPaymentUrl()) {
    • Damien Moulard @DamienM commented Nov 15, 2024
      Master

      j'ai l'impression que cet attribut n'est plus utile, si ? Auquel cas je propose de le supprimer et la migration associée ?

      j'ai l'impression que cet attribut n'est plus utile, si ? Auquel cas je propose de le supprimer et la migration associée ?
    • Yvon Kerdoncuff @Yvon

      changed this line in version 12 of the diff

      Nov 19, 2024

      changed this line in version 12 of the diff

      changed this line in [version 12 of the diff](https://gl.cooperatic.fr/cooperatic/kohinos-tav/merge_requests/118/diffs?diff_id=3551&start_sha=3e5789d75b22976830d7be5d48b59ee0fce77966#bcacb1b7a2c25e66d936437045623681c1bcfa7c_150_148)
      Toggle commit list
    Please register or sign in to reply
  • Damien Moulard
    @DamienM started a discussion on an old version of the diff Nov 15, 2024
    Last updated by Yvon Kerdoncuff Nov 19, 2024
    src/Repository/PaymentRepository.php
    39 41 return $results[0];
    40 42 }
    41 43 }
    44
    45 /*
    46 * Everytime a user clicks on "Payer en CB" button on the kohinos side,
    47 * a Payment entry is created.
    48 * We want to prevent a user from starting several payments, which can
    49 * lead to duplicates.
    50 * We mark as unvalid Payment that are unvalid when we check them.
    51 */
    52 public function findValidStartingPayment($clientEmail)
    53 {
    54 //At first, this method was created to return the url of an existing starting payment.
    • Damien Moulard @DamienM commented Nov 15, 2024
      Master

      proposition de simplifier ce commentaire une fois cette notion d'url enlevée

      proposition de simplifier ce commentaire une fois cette notion d'url enlevée
    • Yvon Kerdoncuff @Yvon

      changed this line in version 12 of the diff

      Nov 19, 2024

      changed this line in version 12 of the diff

      changed this line in [version 12 of the diff](https://gl.cooperatic.fr/cooperatic/kohinos-tav/merge_requests/118/diffs?diff_id=3551&start_sha=3e5789d75b22976830d7be5d48b59ee0fce77966#fa890eef24bc4271c60dd1aa3735a8bf212552e1_54_54)
      Toggle commit list
    Please register or sign in to reply
  • Yvon Kerdoncuff @Yvon

    added 1 commit

    • fd0f6d90 - cleaning

    Compare with previous version

    Nov 19, 2024

    added 1 commit

    • fd0f6d90 - cleaning

    Compare with previous version

    added 1 commit <ul><li>fd0f6d90 - cleaning</li></ul> [Compare with previous version](https://gl.cooperatic.fr/cooperatic/kohinos-tav/merge_requests/118/diffs?diff_id=3551&start_sha=3e5789d75b22976830d7be5d48b59ee0fce77966)
    Toggle commit list
  • Yvon Kerdoncuff @Yvon

    merged

    Nov 19, 2024

    merged

    merged
    Toggle commit list
  • Yvon Kerdoncuff @Yvon

    mentioned in commit 35ebb0c6

    Nov 19, 2024

    mentioned in commit 35ebb0c6

    mentioned in commit 35ebb0c611400ea69ccd76e5595e14f81ba9bdc3
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
Reference: agplv3/kohinos-tav!118
×

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.