fix error at tav household based cotisation, when cotis amount equals allowance amount

src/Utils/TAVCotisationUtils.php

@@ -162,6 +162,7 @@ class TAVCotisationUtils
 
     /**
      * Method called to create Flux based on allowance amount (for household based allowance).
+     * Only create flux if amount paid != allowance amount. 
      */
     public function applyHouseholdAllowance(Flux $flux) {
         // get allowance
@@ -171,36 +172,39 @@ class TAVCotisationUtils
         // get the mlc amount the user is supposed to receive
         $mlcAllowanceAmount = $adherent->getAllocationAmount();
 
-        if ($flux->getExpediteur() instanceof Siege) {
-            $siege = $flux->getExpediteur();
-        } else {
-            $siege = $flux->getExpediteur()->getGroupe()->getSiege();
-        }
-
         // get the difference between what the user paid and what he•she's supposed to receive
         $amountDiff = $mlcAllowanceAmount - $cotisationAmount;
 
-        if ($amountDiff > 0) {
-            // User should receive more than he•she paid: send a new flux to the user to complete its cotisation
-            $fluxCotis = new CotisationTavReversement();
-            $fluxCotis->setExpediteur($siege);
-            $fluxCotis->setDestinataire($adherent);
-            $fluxCotis->setMontant($amountDiff);
-            $fluxCotis->setReference("Versement de l'allocation complémentaire après paiement de " . $cotisationAmount . "€ pour atteindre une allocation de " . $mlcAllowanceAmount . " MonA.");
-        } else {
-            // User should receive less than he•she paid: fetch the difference from his account 
-            $fluxCotis = new CotisationTavPrelevement();
-            $fluxCotis->setExpediteur($adherent);
-            $fluxCotis->setDestinataire($siege);
-            $fluxCotis->setMontant(-$amountDiff);
-            $fluxCotis->setReference("Réduction de l'allocation correspondant à un paiement de " . $cotisationAmount . "€ pour atteindre une allocation de " . $mlcAllowanceAmount . " MonA.");
-        }
+        // only create new flux if there is a difference
+        if ($amountDiff != 0) {
+            if ($flux->getExpediteur() instanceof Siege) {
+                $siege = $flux->getExpediteur();
+            } else {
+                $siege = $flux->getExpediteur()->getGroupe()->getSiege();
+            }
 
-        $fluxCotis->setOperateur($flux->getOperateur());
-        $fluxCotis->setRole($flux->getRole());
-        $fluxCotis->setMoyen(MoyenEnum::MOYEN_EMLC);
-        $this->em->persist($fluxCotis);
-        $this->operationUtils->executeOperations($fluxCotis);
+            if ($amountDiff > 0) {
+                // User should receive more than he•she paid: send a new flux to the user to complete its cotisation
+                $fluxCotis = new CotisationTavReversement();
+                $fluxCotis->setExpediteur($siege);
+                $fluxCotis->setDestinataire($adherent);
+                $fluxCotis->setMontant($amountDiff);
+                $fluxCotis->setReference("Versement de l'allocation complémentaire après paiement de " . $cotisationAmount . "€ pour atteindre une allocation de " . $mlcAllowanceAmount . " MonA.");
+            } else {
+                // User should receive less than he•she paid: fetch the difference from his account 
+                $fluxCotis = new CotisationTavPrelevement();
+                $fluxCotis->setExpediteur($adherent);
+                $fluxCotis->setDestinataire($siege);
+                $fluxCotis->setMontant(-$amountDiff);
+                $fluxCotis->setReference("Réduction de l'allocation correspondant à un paiement de " . $cotisationAmount . "€ pour atteindre une allocation de " . $mlcAllowanceAmount . " MonA.");
+            }
+    
+            $fluxCotis->setOperateur($flux->getOperateur());
+            $fluxCotis->setRole($flux->getRole());
+            $fluxCotis->setMoyen(MoyenEnum::MOYEN_EMLC);
+            $this->em->persist($fluxCotis);
+            $this->operationUtils->executeOperations($fluxCotis);
+        }
     }
 
     /**