Commit a72ccc57 by Scott

Use early return in qa_user_favorite_set

Also improve comment
parent 9cbb6cbe
......@@ -30,18 +30,27 @@
}
/**
* Set an entity to be favorited or removed from favorites. Handles event reporting.
*
* @param int $userid ID of user assigned to the favorite
* @param string $handle Username of user
* @param string $cookieid Cookie ID of user
* @param string $entitytype Entity type code (one of QA_ENTITY_* constants)
* @param string $entityid ID of the entity being favorited (e.g. postid for questions)
* @param bool $favorite Whether to add favorite (true) or remove favorite (false)
*/
function qa_user_favorite_set($userid, $handle, $cookieid, $entitytype, $entityid, $favorite)
/*
If $favorite is true, set $entitytype and $entityid to be favorites of $userid with $handle and $cookieid, otherwise
remove them from its favorites list. Handles event reporting.
*/
{
require_once QA_INCLUDE_DIR.'qa-db-favorites.php';
require_once QA_INCLUDE_DIR.'qa-app-limits.php';
require_once QA_INCLUDE_DIR.'qa-app-updates.php';
// Make sure the user is not favoriting themselves
if ($entitytype != QA_ENTITY_USER || $userid != $entityid) {
if ($entitytype == QA_ENTITY_USER && $userid == $entityid) {
return;
}
if ($favorite)
qa_db_favorite_create($userid, $entitytype, $entityid);
else
......@@ -75,7 +84,6 @@
qa_report_event($action, $userid, $handle, $cookieid, $params);
}
}
function qa_favorite_q_list_view($questions, $usershtml)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment